Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

Suppress/warnings #1885

Merged
merged 12 commits into from
Aug 22, 2022
Merged

Suppress/warnings #1885

merged 12 commits into from
Aug 22, 2022

Conversation

hilmarf
Copy link
Member

@hilmarf hilmarf commented Aug 19, 2022

we've marked some classes to be deprecated, now there are a lot of compiler warnings... let's ignore at least the ones, that we introduced ourselves

some highlighted commits:

  • fe1c218 - springframework PersistenceConstructor is deprecated, we'll use PersistenceCreator instead
  • 9e02c2d - when the assertion is thrown it could lead to a NullPointerException :-(

@hilmarf hilmarf added this to the 2.27 milestone Aug 19, 2022
@hilmarf hilmarf marked this pull request as ready for review August 19, 2022 09:54
@hilmarf hilmarf requested review from a team, AliceBilc, mfromme and I347361 August 19, 2022 09:54
@hilmarf hilmarf removed the request for review from AliceBilc August 19, 2022 09:54
@hilmarf hilmarf enabled auto-merge (squash) August 19, 2022 09:54
@github-actions
Copy link

github-actions bot commented Aug 19, 2022

Unit Test Results

2 464 tests  ±0   2 463 ✔️ ±0   21m 12s ⏱️ -6s
   215 suites ±0          1 💤 ±0 
   215 files   ±0          0 ±0 

Results for commit 57afac0. ± Comparison against base commit fce39b3.

♻️ This comment has been updated with latest results.

@sonarcloud
Copy link

sonarcloud bot commented Aug 22, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@hilmarf hilmarf merged commit 351622b into main Aug 22, 2022
@hilmarf hilmarf deleted the suppress/warnings branch August 22, 2022 13:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants